TL;DR

too long, didn't read

For each exercise:

The issue describes the problem. Read the code, does the issue describe the problem accurately? In each issue there are some questions to think about when looking at the code.

The pull request is a solution to the issue.
Review the pull request, does the pull request fix the issue?

  • Add comments about what is good, what is bad.
  • Add suggestions for code changes.

Would you accept the pull request as is? If not, why not.

← Working with Pull requests
Reviewing →